build: add support for development on kubernetes cluster#190
Merged
kfirtoledo merged 4 commits intollm-d:mainfrom Jun 25, 2025
Merged
build: add support for development on kubernetes cluster#190kfirtoledo merged 4 commits intollm-d:mainfrom
kfirtoledo merged 4 commits intollm-d:mainfrom
Conversation
shmuelk
requested changes
Jun 19, 2025
shmuelk
requested changes
Jun 22, 2025
shmuelk
previously approved these changes
Jun 22, 2025
elevran
requested changes
Jun 22, 2025
480b2d6 to
75dd637
Compare
elevran
reviewed
Jun 23, 2025
elevran
reviewed
Jun 23, 2025
elevran
reviewed
Jun 23, 2025
elevran
previously approved these changes
Jun 23, 2025
Collaborator
elevran
left a comment
There was a problem hiding this comment.
a few more nits, but LGTM
/approve
23c6f5c to
633fec6
Compare
Collaborator
Author
elevran
reviewed
Jun 24, 2025
Collaborator
|
approved.
|
elevran
previously approved these changes
Jun 24, 2025
elevran
previously approved these changes
Jun 24, 2025
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
shmuelk
requested changes
Jun 24, 2025
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
elevran
approved these changes
Jun 25, 2025
shmuelk
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for development on a Kubernetes cluster using scripts/kubernetes-dev-env.sh.
The script will be created in the namespace user gateway+EPP+VLLM for development.
In addition, adding two Makefiles to target for deployment and cleaning:
env-dev-kubernetesandclean-env-dev-kubernetes